Github user jiazhai commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/133#discussion_r119984799
--- Diff:
distributedlog-core/src/main/java/org/apache/distributedlog/impl/metadata/ZKLogStreamMetadataStore.java
---
@@ -237,15 +227,13 @@ public DistributedLock
createWriteLock(LogMetadataForWriter metadata) {
// Create Read Lock
//
- private Future<Void> ensureReadLockPathExist(final LogMetadata
logMetadata,
+ private CompletableFuture<Void> ensureReadLockPathExist(final
LogMetadata logMetadata,
final String
readLockPath) {
--- End diff --
Please also do the code alignment change here, and line 269, 312, 521, 572.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
