Github user jiazhai commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/133#discussion_r119984852
--- Diff:
distributedlog-core/src/main/java/org/apache/distributedlog/metadata/LogStreamMetadataStore.java
---
@@ -59,7 +59,7 @@
* @param readerId the reader id used for lock
* @return the read lock
*/
- Future<DistributedLock> createReadLock(LogMetadataForReader metadata,
+ CompletableFuture<DistributedLock> createReadLock(LogMetadataForReader
metadata,
Optional<String> readerId);
--- End diff --
Please also do the code alignment change here, and line 83.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
