If there are so many tasks using the "wrong" suffix which means many users accept the file suffix, then the suffix is RIGHT. If want to use the new resource file ,they would better change the DAG definition
------------------ 原始邮件 ------------------ 发件人: "leon bao"<[email protected]>; 发送时间: 2020年5月9日(星期六) 下午5:35 收件人: "dev"<[email protected]>; 主题: Re: [DISCUSSION] Is it allowed to change the resource file suffix when update resource name? @GabryWu for users, if you use a wrong suffix file in many tasks, cloning cannot reduce workload, but renaming can. simon <[email protected]> 于2020年5月9日周六 下午5:17写道： > I suggest allowing to change the resource file suffix，because i think this > operation is infrequent and maybe we can assume by default that it has made > problems in use and developers know the impact of changing the suffix. > > > > > > ------------------&nbsp;原始邮件&nbsp;------------------ > 发件人:&nbsp;"leon bao"<[email protected]&gt;; > 发送时间:&nbsp;2020年5月9日(星期六) 下午5:10 > 收件人:&nbsp;"dev"<[email protected]&gt;; > 抄送:&nbsp;"lgcareer2019"<[email protected]&gt;; > 主题:&nbsp;Re: [DISCUSSION] Is it allowed to change the resource file suffix > when update resource name? > > > > there is a issue about this: > https://github.com/apache/incubator-dolphinscheduler/issues/1397 > > in summary, the issue reporter cannot preview the renamed resource when it > was renamed a wrong suffix. > but i think this is not a bug, because if suffix is wrong,&nbsp; you can > rename > a right one. > > @GabryWu > after writing a long code file, i select a wrong suffix. if cannot rename > the suffix, i have to delete the file and create a new one. It's very > inconvenient. > > > @lgcareer2019 > > We should trust the user, before changing the file suffix, user clearly > know the file suffix is wrong. > At the same time,&nbsp; the resource is used as 'resource id' in task > definition, not 'resource name' ,&nbsp; so there is nothing with the task > when > renaming the resource suffix. > > > > > > GabryWu <[email protected]&gt; 于2020年5月9日周六 下午4:06写道： > > &gt; I think the resource file name (including suffix) can't be changed, > which > &gt; contents can be overwritten.&amp;nbsp;&amp;nbsp; > &gt; Why we should consider two files with different suffix is the same > file ? > &gt; If so ,what's meaning of the file suffix? > &gt; > &gt; > &gt; if user want to delete a resource file, a tips telling that the file > is > &gt; used by some job is better > &gt; > &gt; > &gt; ------------------&amp;nbsp;原始邮件&amp;nbsp;------------------ > &gt; 发件人:&amp;nbsp;"[email protected]"<[email protected] > &amp;gt;; > &gt; 发送时间:&amp;nbsp;2020年5月9日(星期六) 下午3:54 > &gt; 收件人:&amp;nbsp;"dev"<[email protected]&amp;gt;; > &gt; > &gt; 主题:&amp;nbsp;[DISCUSSION] Is it allowed to change the resource file > suffix > &gt; when update resource name? > &gt; > &gt; > &gt; > &gt; Hi Dev Team. > &gt; Here is a short topic[1] to discuss. > &gt; Background > &gt; 1. User has created a resource that which name is example and suffix > is > &gt; txt. > &gt; 2. The above resource has been authorzied to other users and it was > used > &gt; by some process definitons. > &gt; > &gt; To Discuss > &gt; If a user need update the resource name,Is it allowed to change the > &gt; resource file suffix when update resource name? > &gt; > &gt; If it is allowed to change the resource file suffix,May be lead to a > &gt; problem that the tasks those which used this resource maybe executed > &gt; failure. > &gt; If it is not allowed to change the resource file,If created the > resource > &gt; and found the resource suffix is wrong,The user has to delete it and > create > &gt; it again. > &gt; > &gt; Please feel free to discuss. > &gt; > &gt; 1.https://github.com/apache/incubator-dolphinscheduler/issues/2598 > &gt <https://github.com/apache/incubator-dolphinscheduler/issues/2598&gt>; > &gt; > &gt; > &gt; DolphinScheduler(Incubator) PPMC > &gt; Gang Li 李岗 > &gt; > &gt; [email protected]<mailto:[email protected]&amp;gt; > > > > -- > DolphinScheduler(Incubator)&nbsp; PPMC > BaoLiang 鲍亮 > [email protected] -- DolphinScheduler(Incubator) PPMC BaoLiang 鲍亮 [email protected]
