very good, This discussion is very productive, haha
Best Regards --------------- DolphinScheduler(Incubator) PPMC Lidong Dai 代立冬 [email protected] --------------- [email protected] <[email protected]> 于2020年5月14日周四 下午4:48写道： > @caibiao > great,I can modify the backend. > > > > DolphinScheduler(Incubator) PPMC > Gang Li 李岗 > > [email protected]<mailto:[email protected]> > > 发件人： 向偲彪 > 发送时间： 2020-05-14 13:54 > 收件人： dev > 主题： 回复： 回复： [DISCUSSION] Is it allowed to change the resource file suffix > when update resource name? > 1. I agree to modify only unauthorized file resources > 2. May I ask who modified the backend, I can complete the modification of > the frontend > > > > > > DolphinScheduler(Incubator) committer > Caibiao Xiang 向偲彪 > > > ------------------ 原始邮件 ------------------ > 发件人: "[email protected]"<[email protected]>; > 发送时间: 2020年5月14日(星期四) 中午1:42 > 收件人: "dev"<[email protected]>; > 抄送: "gaojun2048"<[email protected]>;"leonbao"< > [email protected]>;"向偲彪"<[email protected]>;"wu_shao_jie"< > [email protected]>;"zhouan"<[email protected]>;"3656562"< > [email protected]>; > 主题: Re: 回复： [DISCUSSION] Is it allowed to change the resource file > suffix when update resource name? > > > > Thanks for detail discussion. > > I saw most agree that the resource suffix can be modified. > But if the user want to rename the resource suffix and this resource is > authorized to other users. It's better to notify others. > > I think we can split it into two topic. > 1.Whether we support modify the resource suffix. > I think if the resource is not authorized to other > users,we reached consensus to modify it.We can support it now. > > 2.If the resource is authorzied to other users,Whether need to notify the > event to other users those who have the permisson of this resource. > I think it's better to create a new email thread to > discuss. Include whether need notify,how to notify and so on. > > > > > DolphinScheduler(Incubator) PPMC > Gang Li 李岗 > > [email protected]<mailto:[email protected]> > > 发件人： GabryWu > 发送时间： 2020-05-11 13:35 > 收件人： dev > 抄送： gaojun2048 > 主题： 回复： 回复： [DISCUSSION] Is it allowed to change the resource file suffix > when update resource name? > 1. All modifications cannot be made silently, and must be approved by the > user, because this may cause errors to others who use this file And loss. > > > Yes ,&nbsp; &nbsp;minority is subordinate to the majority, if so > many users used the resource file, > then we can't simply think the suffix is wrong.&nbsp; > who should make this decision that the suffix is wrong ? > > > ------------------&nbsp;原始邮件&nbsp;------------------ > 发件人:&nbsp;"JUN GAO"<[email protected]&gt;; > 发送时间:&nbsp;2020年5月11日(星期一) 中午1:27 > 收件人:&nbsp;"dev"<[email protected]&gt;; > 抄送:&nbsp;"GabryWu"<[email protected]&gt;; > 主题:&nbsp;Re: 回复： [DISCUSSION] Is it allowed to change the resource > file suffix when update resource name? > > > > I agree with @GabryWu > I think once the resource file is used by others, it is best not to modify > it directly. > For the modification of resource files that can be used by other people, we > should abide by a principle: > 1. All modifications cannot be made silently, and must be approved by the > user, because this may cause errors to others who use this file And loss. > 2. If we need to modify this file, the best way is to create a new file, > and then notify the user that the user can choose to use the new file or > continue to use the original file. > > [email protected] <[email protected]&gt; 于2020年5月9日周六 > 下午7:35写道： > > &gt; May be I didn't describe clearly.I try to describe clearly. > &gt; The resource name I said means the resource full name,it includes > name and > &gt; suffix. > &gt; @GabryWu > &gt; &gt; Why we should consider two files with different suffix > is the same file ? > &gt;&nbsp; If so ,what's meaning of the file suffix? > &gt; > &gt; Now verify the uniqueness of the resource file,it need verfiy the > resource > &gt; full name. > &gt; > &gt; > &gt; > &gt; > &gt; > &gt; DolphinScheduler(Incubator) PPMC > &gt; Gang Li 李岗 > &gt; > &gt; [email protected]<mailto:[email protected]&gt; > &gt; > &gt; 发件人： GabryWu > &gt; 发送时间： 2020-05-09 17:17 > &gt; 收件人： dev > &gt; 抄送： lgcareer2019 > &gt; 主题： 回复： [DISCUSSION] Is it allowed to change the resource file > suffix when > &gt; update resource name? > &gt; after writing a long code file, i select a wrong suffix. if > cannot rename > &gt; the suffix, i have to delete the file and create a new one. It's > very > &gt; inconvenient. > &gt; -------------------------------------- > &gt; convenient is another thing! We should make the logic reasonable. > &gt; If resource file name can't be changed at all, that can avoid a > lot of > &gt; problems. > &gt; We can clone one resource file from another ,which equals to > &gt; DELETING-AND-CREATING > &gt; > &gt; ------------------ 原始邮件 ------------------ > &gt; 发件人: "leon bao"<[email protected]&gt;; > &gt; 发送时间: 2020年5月9日(星期六) 下午5:10 > &gt; 收件人: "dev"<[email protected]&gt;; > &gt; 抄送: "lgcareer2019"<[email protected]&gt;; > &gt; 主题: Re: [DISCUSSION] Is it allowed to change the resource file > suffix when > &gt; update resource name? > &gt; > &gt; there is a issue about this: > &gt; https://github.com/apache/incubator-dolphinscheduler/issues/1397 > &gt > <https://github.com/apache/incubator-dolphinscheduler/issues/1397&gt>; > &gt; in summary, the issue reporter cannot preview the renamed > resource when it > &gt; was renamed a wrong suffix. > &gt; but i think this is not a bug, because if suffix is > wrong,&nbsp; you can rename > &gt; a right one. > &gt; > &gt; @GabryWu > &gt; after writing a long code file, i select a wrong suffix. if > cannot rename > &gt; the suffix, i have to delete the file and create a new one. It's > very > &gt; inconvenient. > &gt; > &gt; > &gt; @lgcareer2019 > &gt; > &gt; We should trust the user, before changing the file suffix, user > clearly > &gt; know the file suffix is wrong. > &gt; At the same time,&nbsp; the resource is used as 'resource id' > in task > &gt; definition, not 'resource name' ,&nbsp; so there is nothing > with the task when > &gt; renaming the resource suffix. > &gt; > &gt; > &gt; > &gt; > &gt; > &gt; GabryWu <[email protected]&gt; 于2020年5月9日周六 下午4:06写道： > &gt; > &gt; &gt; I think the resource file name (including suffix) can't > be changed, which > &gt; &gt; contents can be overwritten.&amp;nbsp;&amp;nbsp; > &gt; &gt; Why we should consider two files with different suffix > is the same file ? > &gt; &gt; If so ,what's meaning of the file suffix? > &gt; &gt; > &gt; &gt; > &gt; &gt; if user want to delete a resource file, a tips telling > that the file is > &gt; &gt; used by some job is better > &gt; &gt; > &gt; &gt; > &gt; &gt; > ------------------&amp;nbsp;原始邮件&amp;nbsp;------------------ > &gt; &gt; 发件人:&amp;nbsp;"[email protected]"< > [email protected]&amp;gt;; > &gt; &gt; 发送时间:&amp;nbsp;2020年5月9日(星期六) 下午3:54 > &gt; &gt; 收件人:&amp;nbsp;"dev"<[email protected] > &amp;gt;; > &gt; &gt; > &gt; &gt; 主题:&amp;nbsp;[DISCUSSION] Is it allowed to change > the resource file suffix > &gt; &gt; when update resource name? > &gt; &gt; > &gt; &gt; > &gt; &gt; > &gt; &gt; Hi Dev Team. > &gt; &gt; Here is a short topic[1] to discuss. > &gt; &gt; Background > &gt; &gt; 1. User has created a resource that which name is > example and suffix is > &gt; &gt; txt. > &gt; &gt; 2. The above resource has been authorzied to other users > and it was used > &gt; &gt; by some process definitons. > &gt; &gt; > &gt; &gt; To Discuss > &gt; &gt; If a user need update the resource name,Is it allowed to > change the > &gt; &gt; resource file suffix when update resource name? > &gt; &gt; > &gt; &gt; If it is allowed to change the resource file suffix,May > be lead to a > &gt; &gt; problem that the tasks those which used this resource > maybe executed > &gt; &gt; failure. > &gt; &gt; If it is not allowed to change the resource file,If > created the resource > &gt; &gt; and found the resource suffix is wrong,The user has to > delete it and > &gt; create > &gt; &gt; it again. > &gt; &gt; > &gt; &gt; Please feel free to discuss. > &gt; &gt; > &gt; &gt; 1. > https://github.com/apache/incubator-dolphinscheduler/issues/2598 > &gt > <https://github.com/apache/incubator-dolphinscheduler/issues/2598&gt>; > &gt; > &gt; &gt; > &gt; &gt; > &gt; &gt; DolphinScheduler(Incubator) PPMC > &gt; &gt; Gang Li 李岗 > &gt; &gt; > &gt; &gt; [email protected]<mailto:[email protected] > &amp;gt; > &gt; > &gt; > &gt; > &gt; -- > &gt; DolphinScheduler(Incubator)&nbsp; PPMC > &gt; BaoLiang 鲍亮 > &gt; [email protected] > &gt; > &gt; > > -- > > DolphinScheduler(Incubator)&nbsp; PPMC > Jun Gao 高俊 > [email protected] >
