I agree with @GabryWu I think once the resource file is used by others, it is best not to modify it directly. For the modification of resource files that can be used by other people, we should abide by a principle: 1. All modifications cannot be made silently, and must be approved by the user, because this may cause errors to others who use this file And loss. 2. If we need to modify this file, the best way is to create a new file, and then notify the user that the user can choose to use the new file or continue to use the original file.
lgcareer2...@outlook.com <lgcareer2...@outlook.com> 于2020年5月9日周六 下午7:35写道： > May be I didn't describe clearly.I try to describe clearly. > The resource name I said means the resource full name,it includes name and > suffix. > @GabryWu > > Why we should consider two files with different suffix is the same file ? > If so ,what's meaning of the file suffix? > > Now verify the uniqueness of the resource file,it need verfiy the resource > full name. > > > > > > DolphinScheduler(Incubator) PPMC > Gang Li 李岗 > > lgcareer2...@outlook.com<mailto:lgcareer2...@outlook.com> > > 发件人： GabryWu > 发送时间： 2020-05-09 17:17 > 收件人： dev > 抄送： lgcareer2019 > 主题： 回复： [DISCUSSION] Is it allowed to change the resource file suffix when > update resource name? > after writing a long code file, i select a wrong suffix. if cannot rename > the suffix, i have to delete the file and create a new one. It's very > inconvenient. > -------------------------------------- > convenient is another thing! We should make the logic reasonable. > If resource file name can't be changed at all, that can avoid a lot of > problems. > We can clone one resource file from another ,which equals to > DELETING-AND-CREATING > > ------------------ 原始邮件 ------------------ > 发件人: "leon bao"<leon...@apache.org>; > 发送时间: 2020年5月9日(星期六) 下午5:10 > 收件人: "dev"<dev@dolphinscheduler.apache.org>; > 抄送: "lgcareer2019"<lgcareer2...@outlook.com>; > 主题: Re: [DISCUSSION] Is it allowed to change the resource file suffix when > update resource name? > > there is a issue about this: > https://github.com/apache/incubator-dolphinscheduler/issues/1397 > > in summary, the issue reporter cannot preview the renamed resource when it > was renamed a wrong suffix. > but i think this is not a bug, because if suffix is wrong, you can rename > a right one. > > @GabryWu > after writing a long code file, i select a wrong suffix. if cannot rename > the suffix, i have to delete the file and create a new one. It's very > inconvenient. > > > @lgcareer2019 > > We should trust the user, before changing the file suffix, user clearly > know the file suffix is wrong. > At the same time, the resource is used as 'resource id' in task > definition, not 'resource name' , so there is nothing with the task when > renaming the resource suffix. > > > > > > GabryWu <wu_shao_...@qq.com> 于2020年5月9日周六 下午4:06写道： > > > I think the resource file name (including suffix) can't be changed, which > > contents can be overwritten. > > Why we should consider two files with different suffix is the same file ? > > If so ,what's meaning of the file suffix? > > > > > > if user want to delete a resource file, a tips telling that the file is > > used by some job is better > > > > > > ------------------ 原始邮件 ------------------ > > 发件人: "lgcareer2...@outlook.com"<lgcareer2...@outlook.com>; > > 发送时间: 2020年5月9日(星期六) 下午3:54 > > 收件人: "dev"<dev@dolphinscheduler.apache.org>; > > > > 主题: [DISCUSSION] Is it allowed to change the resource file suffix > > when update resource name? > > > > > > > > Hi Dev Team. > > Here is a short topic[1] to discuss. > > Background > > 1. User has created a resource that which name is example and suffix is > > txt. > > 2. The above resource has been authorzied to other users and it was used > > by some process definitons. > > > > To Discuss > > If a user need update the resource name,Is it allowed to change the > > resource file suffix when update resource name? > > > > If it is allowed to change the resource file suffix,May be lead to a > > problem that the tasks those which used this resource maybe executed > > failure. > > If it is not allowed to change the resource file,If created the resource > > and found the resource suffix is wrong,The user has to delete it and > create > > it again. > > > > Please feel free to discuss. > > > > 1.https://github.com/apache/incubator-dolphinscheduler/issues/2598 > > > > > > > > DolphinScheduler(Incubator) PPMC > > Gang Li 李岗 > > > > lgcareer2...@outlook.com<mailto:lgcareer2...@outlook.com> > > > > -- > DolphinScheduler(Incubator) PPMC > BaoLiang 鲍亮 > leon...@apache.org > > -- DolphinScheduler(Incubator) PPMC Jun Gao 高俊 gaojun2...@gmail.com
