Re: [dpdk-dev] [PATCH 18/39] eventdev: add framework for eventmode conf

[Anoob Joseph]

Hi Jerin,

Please see inline.

Thanks,
Anoob

> -----Original Message-----
> From: Jerin Jacob Kollanukkaran
> Sent: Monday, June 10, 2019 3:36 PM
> To: Anoob Joseph <ano...@marvell.com>; Nikhil Rao <nikhil....@intel.com>;
> Erik Gabriel Carrillo <erik.g.carri...@intel.com>; Abhinandan Gujjar
> <abhinandan.guj...@intel.com>; Bruce Richardson
> <bruce.richard...@intel.com>; Pablo de Lara
> <pablo.de.lara.gua...@intel.com>
> Cc: Anoob Joseph <ano...@marvell.com>; Narayana Prasad Raju Athreya
> <pathr...@marvell.com>; dev@dpdk.org; Lukas Bartosik
> <lbarto...@marvell.com>; Pavan Nikhilesh Bhagavatula
> <pbhagavat...@marvell.com>; Hemant Agrawal <hemant.agra...@nxp.com>;
> Nipun Gupta <nipun.gu...@nxp.com>; Harry van Haaren
> <harry.van.haa...@intel.com>; Mattias Rönnblom
> <mattias.ronnb...@ericsson.com>; Liang Ma <liang.j...@intel.com>
> Subject: RE: [PATCH 18/39] eventdev: add framework for eventmode conf
> 
> > -----Original Message-----
> > From: Anoob Joseph <ano...@marvell.com>
> > Sent: Monday, June 3, 2019 11:02 PM
> > To: Jerin Jacob Kollanukkaran <jer...@marvell.com>; Nikhil Rao
> > <nikhil....@intel.com>; Erik Gabriel Carrillo
> > <erik.g.carri...@intel.com>; Abhinandan Gujjar
> > <abhinandan.guj...@intel.com>; Bruce Richardson
> > <bruce.richard...@intel.com>; Pablo de Lara
> > <pablo.de.lara.gua...@intel.com>
> > Cc: Anoob Joseph <ano...@marvell.com>; Narayana Prasad Raju Athreya
> > <pathr...@marvell.com>; dev@dpdk.org; Lukas Bartosik
> > <lbarto...@marvell.com>; Pavan Nikhilesh Bhagavatula
> > <pbhagavat...@marvell.com>; Hemant Agrawal
> <hemant.agra...@nxp.com>;
> > Nipun Gupta <nipun.gu...@nxp.com>; Harry van Haaren
> > <harry.van.haa...@intel.com>; Mattias Rönnblom
> > <mattias.ronnb...@ericsson.com>; Liang Ma <liang.j...@intel.com>
> > Subject: [PATCH 18/39] eventdev: add framework for eventmode conf
> >
> > Adding eventmode conf which would have all required configuration for
> > the event mode.
> >
> > Signed-off-by: Anoob Joseph <ano...@marvell.com>
> > Signed-off-by: Lukasz Bartosik <lbarto...@marvell.com>
> > ---
> >  lib/librte_eventdev/rte_eventmode_helper.c          | 16 ++++++++++++++++
> >  lib/librte_eventdev/rte_eventmode_helper_internal.h |  5 +++++
> >  2 files changed, 21 insertions(+)
> >
> > diff --git a/lib/librte_eventdev/rte_eventmode_helper.c
> > b/lib/librte_eventdev/rte_eventmode_helper.c
> > index dc2c934..38f1a2b 100644
> > --- a/lib/librte_eventdev/rte_eventmode_helper.c
> > +++ b/lib/librte_eventdev/rte_eventmode_helper.c
> > @@ -97,6 +97,7 @@ rte_eventmode_helper_parse_args(int argc, char
> > **argv)  {
> >     int32_t opt, ret;
> >     struct rte_eventmode_helper_conf *conf = NULL;
> > +   struct eventmode_conf *em_conf = NULL;
> >
> >     /* Allocate memory for conf */
> >     conf = rte_zmalloc("eventmode-helper-conf",
> > @@ -108,9 +109,21 @@ rte_eventmode_helper_parse_args(int argc, char
> > **argv)
> >                     goto err;
> >     }
> >
> > +   /* Allocate memory for event mode params */
> > +   conf->mode_params = rte_zmalloc("eventmode-helper-mode-
> > params",
> 
> Use hugepage alloc memory only fastpath. Malloc() would be fine here.
> 

[Anoob] Will fix this in v2.