On Thu, 13 Aug 2020 16:21:43 -0700, Narcisa Ana Maria Vasile wrote: > From: Harini Ramakrishnan <haram...@microsoft.com> > > Signed-off-by: Harini Ramakrishnan <haram...@microsoft.com> > --- > kernel/windows/netuio/netuio.inf | 3 +- > kernel/windows/netuio/netuio.rc | Bin 4772 -> 8098 bytes > kernel/windows/netuio/netuio_dev.c | 32 +++++++++++++++++++-- > kernel/windows/netuio/netuio_dev.h | 32 +++++++++++++++++++-- > kernel/windows/netuio/netuio_drv.c | 34 ++++++++++++++++++++--- > kernel/windows/netuio/netuio_drv.h | 32 +++++++++++++++++++-- > kernel/windows/netuio/netuio_interface.h | 34 ++++++++++++++++++++--- > kernel/windows/netuio/netuio_queue.c | 34 ++++++++++++++++++++--- > kernel/windows/netuio/netuio_queue.h | 34 ++++++++++++++++++++--- > 9 files changed, 208 insertions(+), 27 deletions(-)
Why not use proper license from the commit each file is introduced? I'm not even sure it is allowed to add files under unapproved license. Please use "SPDX-License-Identifier: BSD-3-Clause" line to indicate licensing. In fact, there was a cleanup of license boilerplate in DPDK some time ago. Lastly, commit topic should be "windows/netuio" and there's an colon in the end (a typo?).