On Mon, Apr 01, 2024 at 10:28:52PM +0000, Aditya Ambadipudi wrote: > Thanks, Stephen, for the comment. > > Unfortunately, we don't have the dev setup nor the resources to test out this > change using MSVC.
what are the dependencies of this lib? you've provided an agnostic api and unit tests, you can enable it in the build and the CI will provide a minimum test bar. > > Thank you, > Aditya Ambadipudi > > > ________________________________ > From: Stephen Hemminger <step...@networkplumber.org> > Sent: Monday, April 1, 2024 9:05 AM > To: Aditya Ambadipudi <aditya.ambadip...@arm.com> > Cc: dev@dpdk.org <dev@dpdk.org>; jack...@nvidia.com <jack...@nvidia.com>; > ma...@nvidia.com <ma...@nvidia.com>; viachesl...@nvidia.com > <viachesl...@nvidia.com>; roret...@linux.microsoft.com > <roret...@linux.microsoft.com>; konstantin.v.anan...@yandex.ru > <konstantin.v.anan...@yandex.ru>; konstantin.anan...@huawei.com > <konstantin.anan...@huawei.com>; m...@smartsharesystems.com > <m...@smartsharesystems.com>; hof...@lysator.liu.se <hof...@lysator.liu.se>; > Honnappa Nagarahalli <honnappa.nagaraha...@arm.com>; Dhruv Tripathi > <dhruv.tripa...@arm.com>; Wathsala Wathawana Vithanage > <wathsala.vithan...@arm.com>; ganeshadit...@gmail.com > <ganeshadit...@gmail.com>; nd <n...@arm.com> > Subject: Re: [PATCH v1 0/2] deque: add multithread unsafe deque library > > On Sun, 31 Mar 2024 20:37:27 -0500 > Aditya Ambadipudi <aditya.ambadip...@arm.com> wrote: > > > As previously discussed in the mailing list [1] we are sending out this > > patch that provides the implementation and unit test cases for the > > RTE_DEQUE library. This includes functions for creating a RTE_DEQUE > > object. Allocating memory to it. Deleting that object and free'ing the > > memory associated with it. Enqueue/Dequeue functions. Functions for > > zero-copy API. > > > > [1] https://mails.dpdk.org/archives/dev/2023-August/275003.html > > Does this build without errors with the Microsoft Visual C compiler? > > Want to make sure that all new code does not create more work for the > Windows maintainers.
