> On Apr 1, 2024, at 9:00 PM, Stephen Hemminger <[email protected]> > wrote: > > On Tue, 2 Apr 2024 01:35:28 +0000 > Honnappa Nagarahalli <[email protected]> wrote: > >>> On Apr 1, 2024, at 7:47 PM, Stephen Hemminger <[email protected]> >>> wrote: >>> >>> On Mon, 1 Apr 2024 22:28:52 +0000 >>> Aditya Ambadipudi <[email protected]> wrote: >>> >>>> Thanks, Stephen, for the comment. >>>> >>>> Unfortunately, we don't have the dev setup nor the resources to test out >>>> this change using MSVC. >>>> >>>> Thank you, >>>> Aditya Ambadipudi >>> >>> All it requires is the community version of MSVC which is free. And setting >>> up a Windows >>> VM with KVM is free and easy. >>> >>> IMHO all new libraries have to build on all environments, unless they are >>> enabling >>> platform specific features. >> I see that UNH CI is running Windows VMs, the tests are passing there. So, >> we do not need to anything. >> > > That only tests the clang part. > You need to modify lib/meson.build to get it tested with the windows compiler. Any idea on when is this getting added to CI?
- [PATCH v1 0/2] deque: add multithread unsafe deque li... Aditya Ambadipudi
- [PATCH v1 1/2] deque: add multi-thread unsafe do... Aditya Ambadipudi
- [PATCH v1 2/2] deque: add unit tests for the deq... Aditya Ambadipudi
- Re: [PATCH v1 0/2] deque: add multithread unsafe... Stephen Hemminger
- Re: [PATCH v1 0/2] deque: add multithread un... Aditya Ambadipudi
- Re: [PATCH v1 0/2] deque: add multithrea... Tyler Retzlaff
- Re: [PATCH v1 0/2] deque: add multithrea... Stephen Hemminger
- Re: [PATCH v1 0/2] deque: add multit... Honnappa Nagarahalli
- Re: [PATCH v1 0/2] deque: add m... Stephen Hemminger
- Re: [PATCH v1 0/2] deque: a... Honnappa Nagarahalli
- Re: [PATCH v1 0/2] dequ... Stephen Hemminger
- Re: [PATCH v1 0/2] dequ... Tyler Retzlaff
- Re: [PATCH v1 0/2] dequ... Stephen Hemminger
- Re: [PATCH v1 0/2] dequ... Honnappa Nagarahalli
- Variable name issues wi... Stephen Hemminger
- Re: [PATCH v1 0/2] dequ... Tyler Retzlaff
- Re: [PATCH v1 0/2] dequ... Honnappa Nagarahalli
- Re: [PATCH v1 0/2] dequ... Tyler Retzlaff
- Re: [PATCH v1 0/2] deque: add multit... Mattias Rönnblom
- Re: [PATCH v1 0/2] deque: add m... Stephen Hemminger

