Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/159#discussion_r39996854
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/FallbackOptionManager.java
---
@@ -83,14 +84,30 @@ public OptionValue getOption(final String name) {
*/
abstract boolean setLocalOption(OptionValue value);
+ /**
+ * Deletes the option with given name for this manager without falling
back.
+ *
+ * @param type option type
+ * @return true iff the option was successfully deleted
--- End diff --
this javadoc can have multiple meanings: _successfully deleted_ could
either mean the implementation couldn't find the option, or it doesn't support
the option type. It should actually return false if it doesn't support the
option type
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
