Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/159#discussion_r39997945
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java
---
@@ -241,6 +243,30 @@ public void setOption(final OptionValue value) {
}
@Override
+ public void deleteOption(final String name, OptionType type) {
+ assert type == OptionType.SYSTEM;
+ try { // ensure option exists
--- End diff --
you can extract this try block as a static method `ensureOptionExists`,
this same code is duplicated in multiple places
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
