Github user adeneche commented on a diff in the pull request:

    https://github.com/apache/drill/pull/159#discussion_r40014413
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/CompoundIdentifierConverter.java
 ---
    @@ -161,6 +171,7 @@ public SqlNode visitChild(
         rules.put(SqlJoin.class, R(D, D, D, D, D, E));
         rules.put(SqlOrderBy.class, R(D, E, D, D));
         rules.put(SqlDropTable.class, R(D));
    +    rules.put(SqlSetOption.class, R(D, D, D));
    --- End diff --
    
    the comment doesn't explain why this specific rule has been added. It just 
explains how the rules work in general.
    Why do we need this specific rule, what happens if I remove it ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to