Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/738#discussion_r99712967
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileWrapper.java
---
@@ -122,6 +125,31 @@ public String getQueryId() {
return id;
}
+ public String getPlanningDuration() {
+ //Check if Plan End is valid
+ if (profile.getStart() > profile.getPlanEnd()) {
--- End diff --
Code clarity is always a goal. One handy technique is to pick off
conditions quickly. Here, we could do:
```
if (profile.getStart() <= profile.getPlanEnd()) {
return ProfileResources.getPrettyDuration(profile.getStart(),
profile.getPlanEnd());
}
// Don't estimate...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
