Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/738#discussion_r100925486
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -417,6 +417,9 @@ private void parseAndRunPhysicalPlan(final String json)
throws ExecutionSetupExc
private void runPhysicalPlan(final PhysicalPlan plan) throws
ExecutionSetupException {
validatePlan(plan);
+ //Marking endTime of Planning
+ queryManager.markPlanningEndTime();
--- End diff --
Right. The method actually is multiple steps..
1. Validate Plan
2. SortMemAllocations
3. Wait In Queue
4. Setup Fragments
5. Execute...
I wanted to explicitly provide the delta time until step 1.
Step 2 is not related to planning (though we can consider including it).
Logically, it is planning.
Step 3 is probably useful only in the RM scenario, but I cannot estimate it
for older profiles. Let's file a **separate** JIRA for this bit? It most
certainly involves another addition to the protobuf.
Step 4. Expected to be a low cost operation like Step 2 and not certainly
related to planning.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
