Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/520#discussion_r103672254
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaDataImpl.java
---
@@ -231,11 +274,16 @@ public boolean storesMixedCaseQuotedIdentifiers()
throws SQLException {
return super.storesMixedCaseQuotedIdentifiers();
}
- // TODO(DRILL-3510): Update when Drill accepts standard SQL's double
quote.
@Override
public String getIdentifierQuoteString() throws SQLException {
throwIfClosed();
- return "`";
+ Property property =
getServerProperty(PlannerSettings.QUOTING_IDENTIFIERS_CHARACTER_KEY);
+ for (Quoting value : Quoting.values()) {
+ if (value.string.equals(property.getValue())) {
+ return value.string;
+ }
+ }
+ throw new SQLException("Unknown quoting identifier character " +
property.getValue());
--- End diff --
Agree. I will add it after merging your's PRs (#613 and #764) to use logic
from there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
