Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/520#discussion_r99866661
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/TypeValidators.java
---
@@ -204,10 +204,11 @@ public void validate(final OptionValue v, final
OptionManager manager) {
* Validator that checks if the given value is included in a list of
acceptable values. Case insensitive.
*/
public static class EnumeratedStringValidator extends StringValidator {
- private final Set<String> valuesSet = new HashSet<>();
+ private final Set<String> valuesSet = new LinkedHashSet<>();
public EnumeratedStringValidator(String name, String def, String...
values) {
super(name, def);
+ valuesSet.add(def.toLowerCase());
--- End diff --
For example
[PARQUET_WRITER_COMPRESSION_TYPE_VALIDATOR](https://github.com/apache/drill/blob/ddcf89548bd33c0cd3e062f1f6d5027eed822372/exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java#L145)
uses mentioned approach - `snappy` value is present twice.
Adding of the default value to the set will allow do not duplicate this
value in the set of acceptable values.
Using of LinkedHashSet will allow to know that the default value is a first
value in the set.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
