Github user vdiravka commented on a diff in the pull request:

    https://github.com/apache/drill/pull/520#discussion_r106453245
  
    --- Diff: 
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaDataImpl.java
 ---
    @@ -184,6 +184,17 @@ private ServerMeta getServerMeta() throws SQLException 
{
         return serverMeta;
       }
     
    +  /**
    +   * The same as {@link DrillDatabaseMetaDataImpl#getServerMeta()} but 
updates server metadata for the every call
    +   * @return server meta information
    +   * @throws SQLException for error when getting server meta
    +   */
    +  private ServerMeta getUpdatedServerMeta() throws SQLException {
    --- End diff --
    
    You are right regarding SQLServer JDBC metadata.
    Eventually I think for now we can left `getIdentifierQuoteString()` without 
updating for every call until it will be really necessary to handle direct 
session changes in DatabaseMetadata.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to