Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/774#discussion_r146133289 --- Diff: contrib/storage-opentsdb/src/main/java/org/apache/drill/exec/store/openTSDB/client/OpenTSDB.java --- @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.store.openTSDB.client; + +import org.apache.drill.exec.store.openTSDB.client.query.DBQuery; +import org.apache.drill.exec.store.openTSDB.dto.MetricDTO; +import retrofit2.Call; +import retrofit2.http.Body; +import retrofit2.http.GET; +import retrofit2.http.POST; +import retrofit2.http.Query; + +import java.util.Set; + +/** + * Client for API requests to openTSDB + */ +public interface OpenTSDB { + + /** + * Used for getting all metrics names from openTSDB + * + * @return Set<String> with all tables names + */ + @GET("api/suggest?type=metrics&max=999") --- End diff -- Why max value is 999? What is we have more metrics? If it is required can we make it configurable?
---