Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/774#discussion_r147582988
  
    --- Diff: 
contrib/storage-opentsdb/src/main/java/org/apache/drill/exec/store/openTSDB/OpenTSDBSubScan.java
 ---
    @@ -0,0 +1,134 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.store.openTSDB;
    +
    +import com.fasterxml.jackson.annotation.JacksonInject;
    +import com.fasterxml.jackson.annotation.JsonCreator;
    +import com.fasterxml.jackson.annotation.JsonIgnore;
    +import com.fasterxml.jackson.annotation.JsonProperty;
    +import com.fasterxml.jackson.annotation.JsonTypeName;
    +import com.google.common.base.Preconditions;
    +import org.apache.drill.common.exceptions.ExecutionSetupException;
    +import org.apache.drill.common.expression.SchemaPath;
    +import org.apache.drill.common.logical.StoragePluginConfig;
    +import org.apache.drill.exec.physical.base.AbstractBase;
    +import org.apache.drill.exec.physical.base.PhysicalOperator;
    +import org.apache.drill.exec.physical.base.PhysicalVisitor;
    +import org.apache.drill.exec.physical.base.SubScan;
    +import org.apache.drill.exec.store.StoragePluginRegistry;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.util.Collections;
    +import java.util.Iterator;
    +import java.util.LinkedList;
    +import java.util.List;
    +
    +@JsonTypeName("openTSDB-tablet-scan")
    +public class OpenTSDBSubScan extends AbstractBase implements SubScan {
    +
    +  private static final Logger log =
    +      LoggerFactory.getLogger(OpenTSDBSubScan.class);
    +
    +  @JsonProperty
    +  public final OpenTSDBStoragePluginConfig storage;
    +
    +  private final List<SchemaPath> columns;
    +  private final OpenTSDBStoragePlugin openTSDBStoragePlugin;
    +  private final List<OpenTSDBSubScanSpec> tabletScanSpecList;
    +
    +  @JsonCreator
    +  public OpenTSDBSubScan(@JacksonInject StoragePluginRegistry registry,
    +                         @JsonProperty("storage") StoragePluginConfig 
storage,
    +                         @JsonProperty("tabletScanSpecList") 
LinkedList<OpenTSDBSubScanSpec> tabletScanSpecList,
    +                         @JsonProperty("columns") List<SchemaPath> 
columns) throws ExecutionSetupException {
    +    super((String) null);
    +    openTSDBStoragePlugin = (OpenTSDBStoragePlugin) 
registry.getPlugin(storage);
    +    this.tabletScanSpecList = tabletScanSpecList;
    +    this.storage = (OpenTSDBStoragePluginConfig) storage;
    --- End diff --
    
    Should consider using ` @JsonProperty("storage") 
OpenTSDBStoragePluginConfig storage` instead of casting.


---

Reply via email to