Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/774#discussion_r147582817 --- Diff: contrib/storage-opentsdb/src/main/java/org/apache/drill/exec/store/openTSDB/OpenTSDBStoragePlugin.java --- @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.store.openTSDB; + +import com.fasterxml.jackson.core.type.TypeReference; +import com.fasterxml.jackson.databind.ObjectMapper; +import org.apache.calcite.schema.SchemaPlus; +import org.apache.drill.common.JSONOptions; +import org.apache.drill.exec.server.DrillbitContext; +import org.apache.drill.exec.store.AbstractStoragePlugin; +import org.apache.drill.exec.store.SchemaConfig; +import org.apache.drill.exec.store.openTSDB.client.services.ServiceImpl; +import org.apache.drill.exec.store.openTSDB.schema.OpenTSDBSchemaFactory; + +import java.io.IOException; + +public class OpenTSDBStoragePlugin extends AbstractStoragePlugin { + + private final DrillbitContext context; + + private final OpenTSDBStoragePluginConfig engineConfig; + private final OpenTSDBSchemaFactory schemaFactory; + + private final ServiceImpl db; + + public OpenTSDBStoragePlugin(OpenTSDBStoragePluginConfig configuration, DrillbitContext context, String name) throws IOException { + this.context = context; + this.schemaFactory = new OpenTSDBSchemaFactory(this, name); + this.engineConfig = configuration; + this.db = new ServiceImpl("http://" + configuration.getConnection()); + } + + @Override + public void start() throws IOException { --- End diff -- There is no need to override `start` and `close` methods since they have the same behavior as parent...
---