ppadma commented on a change in pull request #1429: DRILL-6676: Add Union, List
and Repeated List types to Result Set Loader
URL: https://github.com/apache/drill/pull/1429#discussion_r211063114
##########
File path:
exec/vector/src/main/java/org/apache/drill/exec/vector/complex/ListVector.java
##########
@@ -41,25 +43,42 @@
import org.apache.drill.exec.vector.complex.reader.FieldReader;
import org.apache.drill.exec.vector.complex.writer.FieldWriter;
-import java.util.List;
-import java.util.Set;
+import com.google.common.collect.ObjectArrays;
+
+import io.netty.buffer.DrillBuf;
public class ListVector extends BaseRepeatedValueVector {
- private UInt4Vector offsets;
+ public static final String UNION_VECTOR_NAME = "$union$";
+
private final UInt1Vector bits;
- private Mutator mutator = new Mutator();
- private Accessor accessor = new Accessor();
+ private final Mutator mutator = new Mutator();
+ private final Accessor accessor = new Accessor();
private UnionListWriter writer;
private UnionListReader reader;
public ListVector(MaterializedField field, BufferAllocator allocator,
CallBack callBack) {
super(field, allocator);
+ // Can't do this. See below.
Review comment:
what are the implications of this "can't do this" and commented out code
below ? do we want to leave commented out code here ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
