ppadma commented on a change in pull request #1429: DRILL-6676: Add Union, List
and Repeated List types to Result Set Loader
URL: https://github.com/apache/drill/pull/1429#discussion_r212796357
##########
File path:
exec/vector/src/main/java/org/apache/drill/exec/vector/complex/BaseRepeatedValueVector.java
##########
@@ -212,6 +212,18 @@ protected void replaceDataVector(ValueVector v) {
vector = v;
}
+ public void setChildVector(ValueVector childVector) {
+
+ // When created, the list uses the default vector of type LATE.
+ // That entry appears as a child vector. Remove it and add the
+ // new type instead.
+
+ assert vector == DEFAULT_DATA_VECTOR;
+ replaceDataVector(childVector);
Review comment:
ok. let us add the protocol expectations in the comment i.e. please add the
following to the comments.
"Here we are simply asserting that the client is following the basic
protocol: that the child vector can be set only once, to change the original
LATE vector to something else."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
