ppadma commented on a change in pull request #1429: DRILL-6676: Add Union, List
and Repeated List types to Result Set Loader
URL: https://github.com/apache/drill/pull/1429#discussion_r211064165
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/impl/BuildFromSchema.java
##########
@@ -60,17 +90,23 @@ public ObjectWriter add(ColumnMetadata colSchema) {
*/
public void buildTuple(TupleWriter writer, TupleMetadata schema) {
- ParentShim tupleShim = new TupleShim(writer);
+ final ParentShim tupleShim = new TupleShim(writer);
for (int i = 0; i < schema.size(); i++) {
- ColumnMetadata colSchema = schema.metadata(i);
+ final ColumnMetadata colSchema = schema.metadata(i);
buildColumn(tupleShim, colSchema);
}
}
private void buildColumn(ParentShim parent, ColumnMetadata colSchema) {
- if (colSchema.isMap()) {
+ if (colSchema.structureType() == StructureType.MULTI_ARRAY) {
Review comment:
can we have isMultiArray method ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
