paul-rogers commented on a change in pull request #1899: DRILL-7445: Create
batch copier based on result set framework
URL: https://github.com/apache/drill/pull/1899#discussion_r348104135
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/protocol/VectorContainerAccessor.java
##########
@@ -22,41 +22,83 @@
import org.apache.drill.common.expression.SchemaPath;
import org.apache.drill.exec.record.BatchSchema;
+import org.apache.drill.exec.record.RecordBatch;
import org.apache.drill.exec.record.TypedFieldId;
import org.apache.drill.exec.record.VectorContainer;
import org.apache.drill.exec.record.VectorWrapper;
import org.apache.drill.exec.record.WritableBatch;
import org.apache.drill.exec.record.selection.SelectionVector2;
import org.apache.drill.exec.record.selection.SelectionVector4;
+import org.apache.drill.shaded.guava.com.google.common.base.Preconditions;
public class VectorContainerAccessor implements BatchAccessor {
- public static class ContainerAndSv2Accessor extends VectorContainerAccessor {
+ public static class ExtendedContainerAccessor extends
VectorContainerAccessor {
private SelectionVector2 sv2;
+ private SelectionVector4 sv4;
+
+ public void setBatch(RecordBatch batch) {
Review comment:
This exists in anticipation of an upcoming PR. Notice that this form takes a
`RecordBatch`, which possibly holds a SV. This form picks out the container,
does a schema check, then picks out the SV. Added a comment to explain this
fact.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
