ihuzenko commented on a change in pull request #1945: DRILL-7502: Invalid
codegen for typeof() with UNION
URL: https://github.com/apache/drill/pull/1945#discussion_r362886476
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/EvaluationVisitor.java
##########
@@ -1282,11 +1285,9 @@ public HoldingContainer
visitConvertExpression(ConvertExpression e, ClassGenerat
}
}
-
-
private class ConstantFilter extends EvalVisitor {
- private Set<LogicalExpression> constantBoundaries;
+ private final Set<LogicalExpression> constantBoundaries;
public ConstantFilter(Set<LogicalExpression> constantBoundaries) {
super();
Review comment:
```suggestion
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
