paul-rogers commented on a change in pull request #1945: DRILL-7502: Invalid
codegen for typeof() with UNION
URL: https://github.com/apache/drill/pull/1945#discussion_r363565664
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java
##########
@@ -324,7 +323,12 @@ protected DrillRel convertToDrel(RelNode relNode) throws
SqlUnsupportedException
/**
* A shuttle designed to finalize all RelNodes.
*/
- private static class PrelFinalizer extends RelShuttleImpl {
+ public static class PrelFinalizer extends RelShuttleImpl {
+
+ // The non-default constructor appears to be called from Calcite
+ // code when processing Hive-based queries.
+ public PrelFinalizer(DefaultSqlHandler handler) { }
Review comment:
@vvysotskyi, not sure I can explain this. I got a runtime exception that
some code could not create an instance. The error message appeared to indicate
that the code was called via introspection, with the above signature. Adding
the above code made the problem disappear.
I should have noted the test that failed when run in Eclipse.From the
comment, it seemed to be from some of the Hive tests I ran. But, today, those
tests run fine without this addition. So, I removed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
