vvysotskyi commented on a change in pull request #1945: DRILL-7502: Invalid
codegen for typeof() with UNION
URL: https://github.com/apache/drill/pull/1945#discussion_r363369497
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java
##########
@@ -324,7 +323,12 @@ protected DrillRel convertToDrel(RelNode relNode) throws
SqlUnsupportedException
/**
* A shuttle designed to finalize all RelNodes.
*/
- private static class PrelFinalizer extends RelShuttleImpl {
+ public static class PrelFinalizer extends RelShuttleImpl {
+
+ // The non-default constructor appears to be called from Calcite
+ // code when processing Hive-based queries.
+ public PrelFinalizer(DefaultSqlHandler handler) { }
Review comment:
Could you please explain it a little? I thought this is a regular visitor
which is used only in places where its instance is created and used. By the
way, since it doesn't store any state, its instance may be reused.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
