vvysotskyi commented on a change in pull request #1987: DRILL-7589: Set
temporary tests folder for UDF_DIRECTORY_LOCAL, fix allocators closing in
BloomFilterTest, fix permissions issue for TestGracefulShutdown tests
URL: https://github.com/apache/drill/pull/1987#discussion_r381303021
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/udf/dynamic/TestDynamicUDFSupport.java
##########
@@ -104,8 +104,10 @@ public static void buildAndStoreDefaultJars() throws
IOException {
@Before
public void setupNewDrillbit() throws Exception {
udfDir = dirTestWatcher.makeSubDir(Paths.get("udf"));
+ File udfLocalDir = dirTestWatcher.makeSubDir(Paths.get("udf", "local"));
Properties overrideProps = new Properties();
overrideProps.setProperty(ExecConstants.UDF_DIRECTORY_ROOT,
udfDir.getAbsolutePath());
+ overrideProps.setProperty(ExecConstants.UDF_DIRECTORY_LOCAL,
udfLocalDir.getAbsolutePath());
Review comment:
@paul-rogers, thanks for the explanation and pointing to some places of
`drill-module.conf`.
I have also looked at it and found one more place:
```
zk: {
connect: "localhost:2181",
root: "drill",
```
`drill.exec.zk.root` is used in several places as a base directory, and I
think most of the users use its default value, so changing it may cause
problems. Regarding other places, it would be easier to update their values
without affecting users, but I think it would be better to do it in the scope
of another Jira.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
