paul-rogers commented on a change in pull request #1987: DRILL-7589: Set
temporary tests folder for UDF_DIRECTORY_LOCAL, fix allocators closing in
BloomFilterTest, fix permissions issue for TestGracefulShutdown tests
URL: https://github.com/apache/drill/pull/1987#discussion_r381477365
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/udf/dynamic/TestDynamicUDFSupport.java
##########
@@ -104,8 +104,10 @@ public static void buildAndStoreDefaultJars() throws
IOException {
@Before
public void setupNewDrillbit() throws Exception {
udfDir = dirTestWatcher.makeSubDir(Paths.get("udf"));
+ File udfLocalDir = dirTestWatcher.makeSubDir(Paths.get("udf", "local"));
Properties overrideProps = new Properties();
overrideProps.setProperty(ExecConstants.UDF_DIRECTORY_ROOT,
udfDir.getAbsolutePath());
+ overrideProps.setProperty(ExecConstants.UDF_DIRECTORY_LOCAL,
udfLocalDir.getAbsolutePath());
Review comment:
The `zk.root` path is a path on ZK, not the file system. So, my thought is
that the ZK path would not be set as part of the proposed system.
I do agree that we should tackle any fix as another PR. Filed DRILL-7593 to
track the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
