paul-rogers commented on a change in pull request #1987: DRILL-7589: Set
temporary tests folder for UDF_DIRECTORY_LOCAL, fix allocators closing in
BloomFilterTest, fix permissions issue for TestGracefulShutdown tests
URL: https://github.com/apache/drill/pull/1987#discussion_r382192398
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/udf/dynamic/TestDynamicUDFSupport.java
##########
@@ -104,8 +104,10 @@ public static void buildAndStoreDefaultJars() throws
IOException {
@Before
public void setupNewDrillbit() throws Exception {
udfDir = dirTestWatcher.makeSubDir(Paths.get("udf"));
+ File udfLocalDir = dirTestWatcher.makeSubDir(Paths.get("udf", "local"));
Properties overrideProps = new Properties();
overrideProps.setProperty(ExecConstants.UDF_DIRECTORY_ROOT,
udfDir.getAbsolutePath());
+ overrideProps.setProperty(ExecConstants.UDF_DIRECTORY_LOCAL,
udfLocalDir.getAbsolutePath());
Review comment:
Thanks for the explanation. Since that field is supposed to be relative to
the ZK root, it probably should not also be used as a file system path. I
suspect that, somewhere, sometime, somebody got confused.
If you know where those usages are, please add a note to the JIRA ticket; we
should fix those at the same time to us some other config variable for the file
system.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
