paul-rogers commented on issue #1988: DRILL-7590: Refactor plugin registry
URL: https://github.com/apache/drill/pull/1988#issuecomment-588380039
 
 
   @vvysotskyi , most tests now have category tags. Should we use categories to 
select a set of "smoke test" case to run via GitHub? We could exclude "slow" 
and "unlikely" tests for example.
   
   Otherwise, it would be an effort to identify the core set of "smoke tests." 
Every PR is different. One thought is to run a set of high-level tests (i.e. 
queries) that exercise the whole system. If something fails (such as if this PR 
broke some aspect of plugin registration), the smoke tests won't tell us the 
specific source of failure. However, if the smoke tests fail, the developer can 
rerun the full unit test suite to zero in on the specific problem.
   
   That way, if this particular test takes a long time, but exercises much of 
Drill, it would be a good candidate for a smoke test. We'd make the time by 
removing many of the detailed, focused unit tests (such as those created as 
part of this PR.)
   
   You've probably thought about solutions. What do you recommend?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to