paul-rogers commented on issue #1988: DRILL-7590: Refactor plugin registry
URL: https://github.com/apache/drill/pull/1988#issuecomment-589255074
 
 
   @vvysotskyi, the ideal solution is to make the full "pre-commit" test suite 
available to committers. That way, for example, I could help with the commit 
process as I used to do when at MapR. The workflow would then be:
   
   1. Ideally, run the full unit tests on the dev machine. Or, at least unit 
tests around the fix.
   2. A "smoke test" run on GitHub when pushing the branch.
   3. PR and code review.
   4. The full "pre-commit" run by a committer.
   5. Commit.
   
   Drill used to do batch commits on Friday. This meant that some engineer had 
to do the merges and run the pre-commit tests. Took time. In Impala, we each 
ran the equivalent of the pre-commit tests and merged our own patches after 
approval. Since this could be done offline (run in the evening, say), it was 
not as much of a time sink as the old Drill process.
   
   I suppose there are two questions. 1) Do you (or someone on the team) 
understand the current system well enough to set up a duplicate on, say, AWS? 
and, of course, 2) Where do we get funding for the AWS (or GCE) instance? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to