vvysotskyi commented on issue #1988: DRILL-7590: Refactor plugin registry URL: https://github.com/apache/drill/pull/1988#issuecomment-588841695 The problem is that not all contributors run full tests suite before opening the pull request or rerunning it after making some changes. So if we will exclude some tests from GitHub Actions, we would increase cases when some failing tests were found only when doing batch commits, so batch committer would have to find PR which caused the failures, point contributor to the failing test and after that reviewer should do the review again. I like the approach of running focused unit tests for narrowing down the problem, and as you pointed, it may be reached by using existing unit tests categories. I think we should at least document in contribution guide that the way how slow and unlikely tests may be excluded from the tests run in the case of issues to find a simpler test to reproduce the issue. ``` mvn test -DexcludedGroups="org.apache.drill.categories.SlowTest,org.apache.drill.categories.UnlikelyTest,org.apache.drill.categories.SecurityTest" ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
