arina-ielchiieva commented on a change in pull request #2051: DRILL-7696: EVF
v2 scan schema resolution
URL: https://github.com/apache/drill/pull/2051#discussion_r407386905
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/v3/schema/ScanSchemaResolver.java
##########
@@ -78,44 +78,47 @@
public class ScanSchemaResolver {
private static final Logger logger =
LoggerFactory.getLogger(ScanSchemaResolver.class);
- public enum Mode {
- STRICT_PROVIDED_SCHEMA,
- LENIENT_PROVIDED_SCHEMA,
- EARLY_READER_SCHEMA,
- READER_SCHEMA,
- MISSING_COLS
+ /**
+ * Indicates the source of the schema to be analyzed.
+ * Each schema type has subtly different rules. The
+ * schema type allows us to inject those differences inline
+ * within the resolution process. Also, each schema caries
+ * a tag used for error reporting.
+ */
+ public enum SchemaType {
+ STRICT_PROVIDED_SCHEMA("Provided"),
+ LENIENT_PROVIDED_SCHEMA("Provided"),
+ EARLY_READER_SCHEMA("Reader"),
+ READER_SCHEMA("Reader"),
+ MISSING_COLS("Missing columns");
+
+ private final String source;
+
+ SchemaType(String source) {
+ this.source = source;
+ }
+
+ public String source() {
+ return source;
Review comment:
Please fix indention.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
