arina-ielchiieva commented on a change in pull request #2051: DRILL-7696: EVF
v2 scan schema resolution
URL: https://github.com/apache/drill/pull/2051#discussion_r407389519
##########
File path:
exec/vector/src/main/java/org/apache/drill/exec/record/metadata/VariantSchema.java
##########
@@ -215,4 +216,19 @@ public VariantSchema copy() {
}
return copy;
}
+
+ // Note: no hashCode() as these objects are not meant to be keys.
Review comment:
I do understand you intension here, it's about contract about equals and
hash code, which states `if you override equals you must override hash code`.
Though you don't intend to use these class as keys, looking into your `equals`
method, I would state it's not true equals, it compared only certain parts.
To avoid confusion, I suggest you create your own method for comparison and
don't touch equals and hash code at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
