paul-rogers commented on a change in pull request #2051: DRILL-7696: EVF v2
scan schema resolution
URL: https://github.com/apache/drill/pull/2051#discussion_r407743684
##########
File path:
exec/vector/src/main/java/org/apache/drill/exec/record/metadata/VariantSchema.java
##########
@@ -215,4 +216,19 @@ public VariantSchema copy() {
}
return copy;
}
+
+ // Note: no hashCode() as these objects are not meant to be keys.
Review comment:
@arina-ielchiieva, thanks for the second review. I removed `equals()` and
went back to using the existing `isEquivalent()`, but with a revised
implementation. Since I could not use all the handy `Objects` plumbing for
`equals()`, I had to implement some custom stuff to do the same job. Reran all
tests to verify things still work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
