@Mercy, Is it possible to reimplement https://github.com/alibaba/spring-context-support/blob/1.0.2/src/main/java/com/alibaba/spring/util/AnnotationUtils.java so that alibaba/spirng-context-support will not bother us any longer?
Thanks, -Ian. On Thu, Sep 26, 2019 at 11:40 AM Mercy Ma <mercybl...@gmail.com> wrote: > Hi Justin Mclean, > > I'm the author of https://github.com/alibaba/spring-context-support, could > I change the LICENSE of this project to be "Apache License 2.0" to resolve > this issue? > > Kind regards, > Mercy Ma > > On Thu, Sep 26, 2019 at 11:16 AM Justin Mclean <jus...@classsoftware.com> > wrote: > > > Hi, > > > > -1 binding (due to Category X software being included). > > > > I checked: > > - signatures and hashes fine > > - LICENSE is OK (see below) > > - NOTICE is fine > > - There are a couple of files that are missing ASF headers e.g. [1] > > - There are no unexpected binary files > > - can compile from source > > > > This file [4] includes code cloned from here [5] which is under a GPL > > license. [6] This license is not compatible with the ALv2 and is Category > > X. [7] The same issue exists with this file [8]. It looks like other > files > > in that util directory have also been copied from [9]. it’s strange these > > files have an ASF header when they are in a non ASF repo which is > licensed > > under a non ASF license. Given a good explanation for this and those file > > are correctly licensed I’ll change my vote. What the story behind these > > files? > > > > It would be better if the MIT license text was included in the LICENSE or > > it included a local pointer to the text. Information at a URL can change > > over time. > > > > Looking through the code I found a few other minor things that may need > to > > be updated: > > - References to internal JIRA > > http://code.alibabatech.com/jira/browse/DUBBO-XXX that I cannot access. > > - Reference to this URL [2] > > - Reference to this URL [3] in tests. This gives a 404 so I’m not sure if > > those test pass. there are also there reference to http://dubbo.io. > > > > Thanks, > > Justin > > > > 1. ./apache-dubbo-2.7.4-src/licenseCheck.sh > > 2. http://b2b-doc.alibaba-inc.com/display/RC/dubbo_devguide.htm > > 3. http://dubbo.io/logo.png > > 4. > > > ./apache-dubbo-2.7.4-src/dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/util/AnnotationUtils.java > > 5. > > > https://github.com/alibaba/spring-context-support/blob/1.0.2/src/main/java/com/alibaba/spring/util/AnnotationUtils.java > > 6. https://github.com/alibaba/spring-context-support/blob/1.0.2/LICENSE > > 7. https://apache.org/legal/resolved.html#category-x > > 8. > > > ./apache-dubbo-2.7.4-src/dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/util/ClassUtils.java > > 9. > > > https://github.com/alibaba/spring-context-support/tree/1.0.2/src/main/java/com/alibaba/spring/util > > > > -- > > *Mercy Ma* > GMail:mercybl...@gmail.com > Yahoo: mercy.bl...@yahoo.com > Wetchat: mercyblitz-1985 > Twitter : @mercyblitz <http://twitter.com/mercyblitz> > Blog : https://mercyblitz.github.io/ >
