+1 biding. Though I still have questions about how the UT works exactly and agree this issue should better being fixed, I think it should not be a release blocker and can be done the next time. Xinming has clearly stated, the origin of the zookeeper jar file hosted in her[1] is an official zookeeper release.
1. https://github.com/dubbogo/resources Jun > On Nov 13, 2019, at 9:19 AM, Jun Liu <liu...@apache.org> wrote: > > Sorry, I just noticed that you stated that’s no source code change. But I > still don’t how did you achieved that without changing any source. > > Jun > >> On Nov 13, 2019, at 9:08 AM, Jun Liu <liu...@apache.org> wrote: >> >> Hi, Xinming >> >>> I changed the zookeeper fatjar which will be download by executing >>> before_ut.sh file to a clearly resource from [1] ,which is official website >>> of apache zookeeper. >> >> >> Do you mean you repackaged the source? If so, I think we need to start a new >> thread like 'v1.2.0 RC2' to vote. >> >> Jun >> >>> On Nov 8, 2019, at 7:28 PM, xinming he <hxmhlt0...@gmail.com> wrote: >>> >>> Hi, >>> I changed the zookeeper fatjar which will be download by executing >>> before_ut.sh file to a clearly resource from [1] ,which is official website >>> of apache zookeeper. >>> And because the website does not provide the link of fatjar file, we need >>> to download the whole release package of zookeeper-3.4.9 to separate the >>> fatjar file from it, so I still put it in the previous github project[2]. >>> The dubbo-go code has no changed so I do not need to create a new release. >>> >>> I will continue to wait for your vote to release Apache Dubbo go v1.2.0 RC1. >>> >>> Thanks, >>> Xinming He. >>> >>> 1.https://archive.apache.org/dist/zookeeper/zookeeper-3.4.9/ >>> <https://archive.apache.org/dist/zookeeper/zookeeper-3.4.9/> >>> 2.https://github.com/dubbogo/resources/raw/master/zookeeper-4unitest/contrib/fatjar/zookeeper-3.4.9-fatjar.jar >>> >>> <https://github.com/dubbogo/resources/raw/master/zookeeper-4unitest/contrib/fatjar/zookeeper-3.4.9-fatjar.jar> >>> Jun Liu <liu...@apache.org <mailto:liu...@apache.org>> 于2019年11月5日周二 >>> 上午11:47写道： >>> Hi, Xinming >>> >>> As Justin has pointed. It’s fine to use some binary files during developing >>> and include them in the source repo. What volatiles the Apache rule is that >>> we cannot package any binary files into the Apache source release >>> package[1], that should be excluded when packaging if there’s any in the >>> source repo. >>> >>> 1. https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v1.2.0-rc1/ >>> <https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v1.2.0-rc1/> >>> >>> Jun >>> >>>> On Nov 4, 2019, at 9:03 PM, xinming he <xinmin...@apache.org >>>> <mailto:xinmin...@apache.org>> wrote: >>>> >>>> Hi, >>>> >>>> The jar file is used to start the zookeeper process for code unit testing >>>> temporarily which I download it from [1]. Is there any problem? >>>> >>>> Thanks, >>>> Xinming He. >>>> >>>> 1. >>>> http://central.maven.org/maven2/org/apache/zookeeper/zookeeper/3.4.9/zookeeper-3.4.9.jar >>>> >>>> <http://central.maven.org/maven2/org/apache/zookeeper/zookeeper/3.4.9/zookeeper-3.4.9.jar> >>>> >>>> >>>> Justin Mclean <jus...@classsoftware.com <mailto:jus...@classsoftware.com>> >>>> 于2019年11月4日周一 下午4:06写道： >>>> >>>>> Hi, >>>>> >>>>> I noticed that before_ut.sh is missing an execute bit. I also noticed that >>>>> the install script grabs a jar from here [1]. How is that jar produced? >>>>> >>>>> Thanks, >>>>> Justin >>>>> >>>>> 1. >>>>> https://github.com/dubbogo/resources/tree/master/zookeeper-4unitest/contrib/fatjar >>>>> >>>>> <https://github.com/dubbogo/resources/tree/master/zookeeper-4unitest/contrib/fatjar> >>> >> >
