> On Jan. 18, 2016, 7:55 a.m., Deepak Barr wrote: > > client/src/main/java/org/apache/falcon/client/FalconClient.java, line 832 > > <https://reviews.apache.org/r/42449/diff/1/?file=1199867#file1199867line832> > > > > checkIfSuccessful(clientResponse, String.class) > > > > This will probably throw a RuntimeException. The second argument must > > be an instance of APIResult or a subclass of APIResult. > > > > I think we should put an upper bound in checkIfSuccessful() declaration > > and FalconCLIException.fromReponse() declaration as well to capture such > > things in compile time.
Ackd. Will fix. - Ajay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42449/#review114963 ----------------------------------------------------------- On Jan. 18, 2016, 7:24 a.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42449/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2016, 7:24 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1707 > https://issues.apache.org/jira/browse/FALCON-1707 > > > Repository: falcon-git > > > Description > ------- > > Code Refactoring for Falcon Client > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/client/FalconClient.java 3f3a871 > > Diff: https://reviews.apache.org/r/42449/diff/ > > > Testing > ------- > > > Thanks, > > Ajay Yadava > >
