----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42449/#review114967 -----------------------------------------------------------
client/src/main/java/org/apache/falcon/client/FalconClient.java (line 349) <https://reviews.apache.org/r/42449/#comment175805> May be we can have a common method to add all common params (doAsUser), so common changes can be made in single place. Since there is only such param, it might be ok now. But, it sets a good precedence for further changes. client/src/main/java/org/apache/falcon/client/FalconClient.java (line 379) <https://reviews.apache.org/r/42449/#comment175810> validate does not use sendEntityRequestWithObject method, whereas submit and submitAndSchedule use it. Why the difference? client/src/main/java/org/apache/falcon/client/FalconClient.java (line 396) <https://reviews.apache.org/r/42449/#comment175811> Can't use sendEntityRequestWithObject method? client/src/main/java/org/apache/falcon/client/FalconClient.java (line 473) <https://reviews.apache.org/r/42449/#comment175813> Can't use getResponse() method? client/src/main/java/org/apache/falcon/client/FalconClient.java (line 671) <https://reviews.apache.org/r/42449/#comment175814> Can't use getResponse() method? - Pallavi Rao On Jan. 18, 2016, 7:24 a.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42449/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2016, 7:24 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1707 > https://issues.apache.org/jira/browse/FALCON-1707 > > > Repository: falcon-git > > > Description > ------- > > Code Refactoring for Falcon Client > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/client/FalconClient.java 3f3a871 > > Diff: https://reviews.apache.org/r/42449/diff/ > > > Testing > ------- > > > Thanks, > > Ajay Yadava > >
