> On Jan. 18, 2016, 8:40 a.m., Pallavi Rao wrote: > > client/src/main/java/org/apache/falcon/client/FalconClient.java, line 770 > > <https://reviews.apache.org/r/42449/diff/1/?file=1199867#file1199867line770> > > > > Can't use getResponse() method? > > Ajay Yadava wrote: > Yes we can and we should, thanks for catching it. > > Ajay Yadava wrote: > Here also we can't use getResponse() as LineageGraphResult also doesn't > extend APIResult. > > Pallavi Rao wrote: > As before should we file a JIRA to fix this on server-side to extend > APIResult? I think we should be consistent in that all result objects should > extend APIResult.
Created https://issues.apache.org/jira/browse/FALCON-1759 - Ajay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42449/#review114967 ----------------------------------------------------------- On Jan. 19, 2016, 7:38 a.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42449/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2016, 7:38 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1707 > https://issues.apache.org/jira/browse/FALCON-1707 > > > Repository: falcon-git > > > Description > ------- > > Code Refactoring for Falcon Client > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/client/FalconCLIException.java > 831f7ac > client/src/main/java/org/apache/falcon/client/FalconClient.java 3f3a871 > > Diff: https://reviews.apache.org/r/42449/diff/ > > > Testing > ------- > > > Thanks, > > Ajay Yadava > >
