> On Jan. 5, 2016, 9:50 p.m., Balu Vellanki wrote: > > common/src/main/java/org/apache/falcon/entity/FeedHelper.java, line 1183 > > <https://reviews.apache.org/r/41916/diff/1/?file=1181570#file1181570line1183> > > > > What is the purpose of this line?
It's getting the retentionLimit and converting to seconds as per the function. retentionLimit = getCluster(feed, clusterName).getRetention().getLimit(); > On Jan. 5, 2016, 9:50 p.m., Balu Vellanki wrote: > > common/src/main/java/org/apache/falcon/entity/FeedHelper.java, line 1205 > > <https://reviews.apache.org/r/41916/diff/1/?file=1181570#file1181570line1205> > > > > Minor nit : Instead of old (which is a loaded word), can we call this > > getRetentionQueueFromProperties ? This is from previous patch. But I have refactored it to getRetentionQueueFromProperties() > On Jan. 5, 2016, 9:50 p.m., Balu Vellanki wrote: > > common/src/main/java/org/apache/falcon/entity/FeedHelper.java, line 1216 > > <https://reviews.apache.org/r/41916/diff/1/?file=1181570#file1181570line1216> > > > > A reco for future : It would help to have a getProperty(Entity, > > propertyKey) method in EntityUtil instead of duplicating same code in > > ClusterHelper and FeedHelper. should be addressed in a refactor patch. - Venkatesan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41916/#review112934 ----------------------------------------------------------- On Jan. 5, 2016, 5:52 a.m., Venkatesan Ramachandran wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41916/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2016, 5:52 a.m.) > > > Review request for Falcon. > > > Repository: falcon-git > > > Description > ------- > > Validate the hadoop cluster queue name specified in the Feed entity during > feed submit. > > The implementation uses Resource Manager REST API to get hadoop cluster queue > names. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/entity/FeedHelper.java 150e0bd > common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java > 981e730 > common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 9841083 > common/src/test/resources/config/feed/feed-schedulerinfo-1.json > PRE-CREATION > common/src/test/resources/config/feed/feed-schedulerinfo-2.json > PRE-CREATION > > oozie/src/main/java/org/apache/falcon/oozie/OozieOrchestrationWorkflowBuilder.java > e137e11 > > Diff: https://reviews.apache.org/r/41916/diff/ > > > Testing > ------- > > Unit tests > Manual end to end tests > Secure cluster test > > > Thanks, > > Venkatesan Ramachandran > >
