> On Jan. 8, 2016, 4:38 a.m., Ajay Yadava wrote: > > common/src/main/java/org/apache/falcon/entity/FeedHelper.java, line 1225 > > <https://reviews.apache.org/r/41916/diff/1/?file=1181570#file1181570line1225> > > > > I think this will be useful for processes also and it will be nice to > > move it outside of FeedHelper to some place more appropriate.
Moved to an Utility class. > On Jan. 8, 2016, 4:38 a.m., Ajay Yadava wrote: > > common/src/main/java/org/apache/falcon/entity/FeedHelper.java, line 1260 > > <https://reviews.apache.org/r/41916/diff/1/?file=1181570#file1181570line1260> > > > > This is very interesting. Can you please share the json which is > > treated as malformed? I had built a custom UI for Yarn which we use at > > Inmobi and I just want to see how different frameworks are handling > > malformed json. examine the returned json "health" node. There are repeating "entry" nodes but inside an array "[". Old json parsers ignore it but if you use the latest ones, you'll get an exception. > On Jan. 8, 2016, 4:38 a.m., Ajay Yadava wrote: > > common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java, > > line 554 > > <https://reviews.apache.org/r/41916/diff/1/?file=1181571#file1181571line554> > > > > This won't work well in distributed mode. You are trying to validate > > queues for all the clusters from each falcon server. This will result in > > lot of redundant validations, even if the url were accessible from all data > > centers. Not sure what you mean. Can you add more details? I also pinged you on this, but yet to hear back. > On Jan. 8, 2016, 4:38 a.m., Ajay Yadava wrote: > > common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java, > > line 567 > > <https://reviews.apache.org/r/41916/diff/1/?file=1181571#file1181571line567> > > > > This will validate only retention queue. Retention queue and > > replication queue can be different and this will validate only retention > > queue. Currently, Lifecycle does not support Replication and so the replication Q is specified via "queueName" property and it is handled. > On Jan. 8, 2016, 4:38 a.m., Ajay Yadava wrote: > > common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java, > > line 715 > > <https://reviews.apache.org/r/41916/diff/1/?file=1181571#file1181571line715> > > > > nit: you can use the diamond operator to avoid IDE warnings We have made Java7 as the baseline and so it's okay. - Venkatesan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41916/#review112898 ----------------------------------------------------------- On Feb. 10, 2016, 10:32 p.m., Venkatesan Ramachandran wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41916/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2016, 10:32 p.m.) > > > Review request for Falcon. > > > Repository: falcon-git > > > Description > ------- > > Validate the hadoop cluster queue name specified in the Feed entity during > feed submit. > > The implementation uses Resource Manager REST API to get hadoop cluster queue > names. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/entity/FeedHelper.java b3aaaab > common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java > 981e730 > > common/src/main/java/org/apache/falcon/entity/parser/ProcessEntityParser.java > 10a5265 > common/src/main/java/org/apache/falcon/util/HadoopQueueUtil.java > PRE-CREATION > common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 95d10c4 > common/src/test/java/org/apache/falcon/util/HadoopQueueUtilTest.java > PRE-CREATION > common/src/test/resources/config/feed/feed-schedulerinfo-1.json > PRE-CREATION > common/src/test/resources/config/feed/feed-schedulerinfo-2.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/41916/diff/ > > > Testing > ------- > > Unit tests > Manual end to end tests > Secure cluster test > > > Thanks, > > Venkatesan Ramachandran > >
