----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19096/#review36912 -----------------------------------------------------------
client/src/main/java/org/apache/falcon/LifeCycle.java <https://reviews.apache.org/r/19096/#comment68102> These lifecycle values are only for Feed. We may have lifecycles for process later. It would be better we name the ENUM values appropriately. common/src/main/java/org/apache/falcon/entity/EntityUtil.java <https://reviews.apache.org/r/19096/#comment68103> I don't see this function being used anywhere common/src/main/java/org/apache/falcon/hadoop/HadoopClientFactory.java <https://reviews.apache.org/r/19096/#comment68104> Unnecesary line deletion - Suhas Vasu On March 12, 2014, 11:14 a.m., pavan kumar kolamuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19096/ > ----------------------------------------------------------- > > (Updated March 12, 2014, 11:14 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-240 > https://issues.apache.org/jira/browse/FALCON-240 > > > Repository: falcon-git > > > Description > ------- > > Added lifecycle option in falcon which is used to view the retention details > of feed > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/LifeCycle.java PRE-CREATION > client/src/main/java/org/apache/falcon/cli/FalconCLI.java c8ce780 > client/src/main/java/org/apache/falcon/client/FalconClient.java f008953 > common/src/main/java/org/apache/falcon/entity/EntityUtil.java b4bc07d > common/src/main/java/org/apache/falcon/hadoop/HadoopClientFactory.java > d5fbda8 > > common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java > f700b8f > > hadoop-dependencies/src/main/java/org/apache/falcon/hadoop/JailedFileSystem.java > e12a509 > > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java > dee77c0 > prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java > 07ab2bc > > prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java > 407f39a > test-util/src/main/java/org/apache/falcon/cluster/util/EmbeddedCluster.java > af29f93 > webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java > fd3cd51 > webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 5cd7beb > > Diff: https://reviews.apache.org/r/19096/diff/ > > > Testing > ------- > > There are Unit test cases for this. > > > Thanks, > > pavan kumar kolamuri > >
