----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19096/#review38681 -----------------------------------------------------------
client/src/main/java/org/apache/falcon/LifeCycle.java <https://reviews.apache.org/r/19096/#comment70954> Why is Process execution not a lifecycle? Also, having the entity type and a tag applicable to each lifecycle makes sense. Lifecycle(EntityType entityType, Tag tag) EXECUTION(EntityType.PROCESS, Tag.DEFAULT) EVICT(EntityType.FEED, Tag.RETENTION) REPLICATE(EntityType.FEED, Tag.REPLICATION) client/src/main/java/org/apache/falcon/cli/FalconCLI.java <https://reviews.apache.org/r/19096/#comment70965> Why would you have multiple life cycles? Option says Lifecycle. common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java <https://reviews.apache.org/r/19096/#comment70966> Do not do this, convert to *. oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java <https://reviews.apache.org/r/19096/#comment70967> Can you move this into a method for clarity? Also this needs to be rebased. test-util/src/main/java/org/apache/falcon/cluster/util/EmbeddedCluster.java <https://reviews.apache.org/r/19096/#comment70969> Why is this removed? This is necessary. webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java <https://reviews.apache.org/r/19096/#comment70971> There is one defined in SchemaHelper, use that. webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java <https://reviews.apache.org/r/19096/#comment70972> Is this option optional? if so, what is the default. I do not see a test case for multiple lifecycle options. webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java <https://reviews.apache.org/r/19096/#comment70975> There is no update to Documentation. Please update the doc for both CLI and REST API with the new option. Also may be FalconDocumentation. webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java <https://reviews.apache.org/r/19096/#comment70973> Please make sure you run the following before uploading the patch. mvn clean verify -Phadoop-2,test-patch - Seetharam Venkatesh On March 26, 2014, 10:07 a.m., pavan kumar kolamuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19096/ > ----------------------------------------------------------- > > (Updated March 26, 2014, 10:07 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-240 > https://issues.apache.org/jira/browse/FALCON-240 > > > Repository: falcon-git > > > Description > ------- > > Added lifecycle option in falcon which is used to view the retention details > of feed > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/LifeCycle.java PRE-CREATION > client/src/main/java/org/apache/falcon/cli/FalconCLI.java c8ce780 > client/src/main/java/org/apache/falcon/client/FalconClient.java f008953 > common/src/main/java/org/apache/falcon/entity/EntityUtil.java b4bc07d > > common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java > f700b8f > > hadoop-dependencies/src/main/java/org/apache/falcon/hadoop/JailedFileSystem.java > e12a509 > > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java > dee77c0 > prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java > 07ab2bc > > prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java > 407f39a > test-util/src/main/java/org/apache/falcon/cluster/util/EmbeddedCluster.java > af29f93 > webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java > fd3cd51 > webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 5cd7beb > > Diff: https://reviews.apache.org/r/19096/diff/ > > > Testing > ------- > > There are Unit test cases for this. > > > Thanks, > > pavan kumar kolamuri > >
