----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19096/#review42496 -----------------------------------------------------------
client/src/main/java/org/apache/falcon/cli/FalconCLI.java <https://reviews.apache.org/r/19096/#comment76286> type is not required here. Add lifecycle to type check in FalconClient oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java <https://reviews.apache.org/r/19096/#comment76287> rename display.count to displaycount? oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java <https://reviews.apache.org/r/19096/#comment76289> call isRetentionCoord(coord) once per coord and store in variable and re-use oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java <https://reviews.apache.org/r/19096/#comment76290> should be start<end oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java <https://reviews.apache.org/r/19096/#comment76291> rename wfName to coordName prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java <https://reviews.apache.org/r/19096/#comment76292> extract entityType from type outside for loop and then use == prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java <https://reviews.apache.org/r/19096/#comment76293> this check should be entity type != lifecycle.tag.type prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java <https://reviews.apache.org/r/19096/#comment76294> throw FalconException The exception should contain the exact lifecycle and type so that its easier for users to understand the exception webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java <https://reviews.apache.org/r/19096/#comment76295> duplicate - shwethags On May 8, 2014, 10:12 a.m., pavan kumar kolamuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19096/ > ----------------------------------------------------------- > > (Updated May 8, 2014, 10:12 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-240 > https://issues.apache.org/jira/browse/FALCON-240 > > > Repository: falcon-git > > > Description > ------- > > Added lifecycle option in falcon which is used to view the retention details > of feed > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/LifeCycle.java PRE-CREATION > client/src/main/java/org/apache/falcon/cli/FalconCLI.java 33f52c4 > client/src/main/java/org/apache/falcon/client/FalconClient.java 5d9701f > client/src/main/java/org/apache/falcon/entity/v0/SchemaHelper.java 9061a9e > > common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java > f700b8f > docs/src/site/twiki/FalconCLI.twiki 149aaa3 > docs/src/site/twiki/restapi/InstanceKill.twiki eff2893 > docs/src/site/twiki/restapi/InstanceLogs.twiki 599f2d7 > docs/src/site/twiki/restapi/InstanceRerun.twiki 77608e0 > docs/src/site/twiki/restapi/InstanceResume.twiki 2d29569 > docs/src/site/twiki/restapi/InstanceRunning.twiki 116565f > docs/src/site/twiki/restapi/InstanceStatus.twiki 99497d1 > docs/src/site/twiki/restapi/InstanceSummary.twiki bd1d2e5 > docs/src/site/twiki/restapi/InstanceSuspend.twiki 8f5f7c3 > > hadoop-dependencies/src/main/java/org/apache/falcon/hadoop/JailedFileSystem.java > e12a509 > > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java > 9d4103b > prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java > 07ab2bc > > prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java > 407f39a > test-util/src/main/java/org/apache/falcon/cluster/util/EmbeddedCluster.java > af29f93 > webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java > fd3cd51 > webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java b6c5054 > > Diff: https://reviews.apache.org/r/19096/diff/ > > > Testing > ------- > > There are Unit test cases for this. > > > Thanks, > > pavan kumar kolamuri > >
