Richard S. Hall wrote:
+1
You should just delete the generated bz2 files and signatures, since we
don't release those.
OK! I will deletes signatures and bz2 files, btw they were automatically
generated by the maven release profile.
Also, it wasn't entirely clear to me where the cgupnpjava was and there
was no license for it, although NOTICE states that it is BSD. Also it
wasn't a dependency in the POM, nor was kxml2...I assume these
dependencies must be embedded in the cyberdomo artifacts.
Yes, you are right, cgupnpjava is embedded within cyberdomo, I can add a
LICENSE.cgupnpjava if you want to. On the contrary, kxml is embedded
with cyberdomo but it is a dependency of cyberdomo.
In NOTICE it lists the same software under both "includes" and
"uses"...is that accurate? It seems that the embedded software should
only be listed under "includes", no?
I will remove them from "uses", I wasn't sure that "includes" comprises
the "uses" meaning, so I have duplicated them
I don't think these issues are major, but should be addressed for the
next release.
Perfect! That were the exactly the feed-back that I needed for the next
releases ;)
-> richard
