Fully agree, I will not add the "Systar" headers, until you add the final Apache headers. As you say, the code does not have to be public.
I just sent an update to Fred, with the changes he asked and a bug fix following the latest refactoring. I will let him get back to his work. Maurice -----Message d'origine----- De : Alex Harui [mailto:aha...@adobe.com] Envoyé : mardi 24 septembre 2013 22:27 À : dev@flex.apache.org Objet : Re: Flex Mobile DataGrid donation submission Hi Maurice, Thanks for spending time cleaning up the code a bit. I just didn't want Fred to feel like he had to keep reviewing since he's short on time. IMO, you could wait to post the next package of code until you get headers in place. You don't even have to do that either, the public doesn't actually have to see the code until the Software Grant is executed. Thanks, -Alex On 9/24/13 1:22 PM, "Maurice Amsellem" <maurice.amsel...@systar.com> wrote: >Since I am almost done with the changes, I will send an update anyway, >in >15 min from now. > >Maurice > >-----Message d'origine----- >De : Frédéric THOMAS [mailto:webdoubl...@hotmail.com] Envoyé : mardi 24 >septembre 2013 22:20 À : dev@flex.apache.org Objet : RE: Flex Mobile >DataGrid donation submission > >So, in that case, that's fine too me. > >-----Message d'origine----- >De : Alex Harui [mailto:aha...@adobe.com] Envoyé : mardi 24 septembre >2013 22:18 À : dev@flex.apache.org Objet : Re: Flex Mobile DataGrid >donation submission > >Fred & Maurice, > >Most/all of this can be fixed post-donation. IMO, the only "required" >part of the code review is to make sure it looks like code and no >obvious third-party/licensing issues. > >-Alex > >On 9/24/13 1:06 PM, "Frédéric THOMAS" <webdoubl...@hotmail.com> wrote: > >>One more point, I guess you should replace the NS >>library://ns.systar.com/fx/mobile and its directory structure with the >>Spark one, see the experimental lib for more details. >> >>The sort on the computed fullname doesn't work but the sort arrow is >>still shown when clicked, is it expected ? >> >>-Fred >> >>-----Message d'origine----- >>De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] >>Envoyé : mardi 24 septembre 2013 21:49 À : dev@flex.apache.org Objet : >>RE:Flex Mobile DataGrid donation submission >> >>Sure, i ll do that >>________________________________________ >>De : Frédéric THOMAS [webdoubl...@hotmail.com] Envoyé : mardi 24 >>septembre >>2013 21:22 À : dev@flex.apache.org Objet : RE: Flex Mobile DataGrid >>donation submission >> >>Maurice, I just noticed some extra import statements and duplicated >>variables, if you used IntelliJ as primary IDE, please run CTRL+ALT+L >>on the src folder and run a code analysis. >> >>Thanks, >>-Fred >> >>-----Message d'origine----- >>De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] >>Envoyé : mardi 24 septembre 2013 20:26 À : dev@flex.apache.org Objet : >>RE: Flex Mobile DataGrid donation submission >> >>I will be also more than happy to provide any explanation on the code >>itself, which I realize is hardly documented. >> >>Maurice >> >>-----Message d'origine----- >>De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] >>Envoyé : mardi 24 septembre 2013 20:23 À : dev@flex.apache.org Objet : >>RE: Flex Mobile DataGrid donation submission >> >>FYI, I just send an update with some refactoring to Fred. >> >>I can send It to anyone else that wants to take the lead on the review. >> >>Maurice >> >>-----Message d'origine----- >>De : Frédéric THOMAS [mailto:webdoubl...@hotmail.com] Envoyé : mardi >>24 septembre 2013 20:21 À : dev@flex.apache.org Objet : RE: Flex >>Mobile DataGrid donation submission >> >>Alex, it is very not the better time for me, I'll start a new contract >>in >>2 >>days and I'm be very busy in between, many last time administrative >>things, etc..., I'm sorry for the inconvenience but if someone else >>could take the lead on that, it would be great. >> >>Moreover, I haven't got any devices at the moment to test it, I could >>had test it only in the emulator but it is not good enough IMO, in >>more folks with more mobile skills/experiences than me would be a >>better choice. >> >>Thanks, >>-Fred >> >>-----Message d'origine----- >>De : Alex Harui [mailto:aha...@adobe.com] Envoyé : mardi 24 septembre >>2013 >>19:57 À : dev@flex.apache.org Objet : Re: Flex Mobile DataGrid >>donation submission >> >>Hi Fred, >> >>IMO, it doesn't matter if it has bugs. If you just take a quick look >>at the code and say it seems reasonably organized and smaller than the >>Spark DG that's good enough for me. Then start some sort of vote >>unless it is really just a few files. Use [VOTE] or [LAZY] or [POLL] >>but IMO, we should draw attention to the fact we're doing this. >> >>-Alex >> >>On 9/24/13 10:43 AM, "Frédéric THOMAS" <webdoubl...@hotmail.com> wrote: >> >>>@Maurice, that's fine, I've got your email with the attachment, so, >>>anyone would like to test it is free to ask me to forward him. >>> >>>@Om, yep, sounds good. >>> >>>-Fred >>> >>>-----Message d'origine----- >>>De : omup...@gmail.com [mailto:omup...@gmail.com] De la part de >>>OmPrakash Muppirala Envoyé : mardi 24 septembre 2013 19:33 À : >>>dev@flex.apache.org; jef...@dot-com-it.com Objet : Re: Flex Mobile >>>DataGrid donation submission >>> >>>On Tue, Sep 24, 2013 at 10:28 AM, Jeffry Houser >>><jef...@dot-com-it.com>wrote: >>> >>>> On 9/24/2013 1:24 PM, Alex Harui wrote: >>>> >>>>> We've been voting on sizeable non-Adobe contributions. Swiz was >>>>> the last vote. >>>>> >>>> >>>> Fair enough. Swiz is an entity separate, but complimentary to the >>>> Flex Framework. It seems like a mobile optimized DataGrid is more >>>> like a really big patch. >>>> >>> >>>I agree. I really dont think we need to vote on this. If some >>>committer wants to veto this, they can go ahead and do so. We can >>>start a discussion about the reasons for the veto at that point. >>> >>>A lazy vote should probably suffice in this case. >>> >>>Thanks, >>>Om >>> >>> >>>> >>>> However, I'm not opposed to voting. >>>> >>>> >>>> >>>> -- >>>> Jeffry Houser >>>> Technical Entrepreneur >>>> http://www.jeffryhouser.com >>>> 203-379-0773 >>>> >>>> >> >
