I have spend the day running all JS files through JSHint and gjslint. I fixed about 6 errors that emerged (vars not declared etc.) up, but I also corrected all whitespace. It's a monster commit, if I get it finished ;-)
Another issue: there is a rather large discrepancy between the class structure on the AS side vs. the JS side. Case in point is the lack of an IBeads interface on the JS side. I think the idea is to make the JS side mirror the structure of the AS side as closely as possible? And lastly (yeah, right... ;-)) how about the examples? Which ones are working for you, either in debug mode or in both debug AND release mode? EdB On Wed, Nov 6, 2013 at 4:48 PM, Peter Ent <p...@adobe.com> wrote: > I checked a number of files in yesterday and I'm pretty sure a handful > won't pass glint right now; I meant to do them all, but forgot some so I'm > doing them this morning. If you want to go ahead and run the tool just to > see if and how failures pop-up, go right ahead. > > --peter > > On 11/6/13 2:40 AM, "Erik de Bruin" <e...@ixsoftware.nl> wrote: > >>Hi, >> >>I would like to run the entire JS framework through the 'gjslint' >>tool. This is the JS linter provided by Google to check code that is >>to be processed by the Closure Compiler. >> >>It has some very strict whitespace rules, that will result in changes >>in most files (although we started out with a clean, gjslint approved >>version a long while ago, when I implemented 'goog' event handling). >> >>The main advantages are that all code will be consistently formatted >>and that it will most likely catch some annotation and related >>errors/omissions. >> >>If no one (Alex, Peter) has commits pending, I am ready to go. >> >>EdB >> >> >> >>-- >>Ix Multimedia Software >> >>Jan Luykenstraat 27 >>3521 VB Utrecht >> >>T. 06-51952295 >>I. www.ixsoftware.nl > -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl
