Ok, let's do it this way: You guys just keep committing (remember to pull before you push ;-)) and I'll fix any merge issues. Once I'm done (I think my tomorrow), I'll put my changes in a new public branch, so we can test against the examples to make sure I didn't break anything.
Also, interfaces are now supported. My commit will contain several 'pure' JS interfaces, including ones that extend other interfaces. Take a look at the "LanguageTests" example for inspiration ;-) I have changed the "interface" storage a bit today, instead of an array just for interfaces it is now an object that can/will contain info about interfaces, metadata and other class information which we can easily add through FalconJx now. Be sure to update both FalconJx and flex-asjs and rebuild everything. Alex, maybe time for a new overlay? EdB On Wed, Nov 6, 2013 at 5:13 PM, Peter Ent <p...@adobe.com> wrote: > I haven't tried all of the example yet. Was going to do that once I > finished up a wiki page and cleaned up the remaining glint issues. > > The discrepancy is known and it is something I have been working on > recently. I haven't attempted any @interface stuff yet, so I created some > base classes to mimic interfaces (e.g., org.apache.flex.core.IBeadView) > but did not create one for org.apache.flex.core.IBead. > > --peter > > On 11/6/13 10:54 AM, "Erik de Bruin" <e...@ixsoftware.nl> wrote: > >>I have spend the day running all JS files through JSHint and gjslint. >>I fixed about 6 errors that emerged (vars not declared etc.) up, but I >>also corrected all whitespace. It's a monster commit, if I get it >>finished ;-) >> >>Another issue: there is a rather large discrepancy between the class >>structure on the AS side vs. the JS side. Case in point is the lack of >>an IBeads interface on the JS side. I think the idea is to make the JS >>side mirror the structure of the AS side as closely as possible? >> >>And lastly (yeah, right... ;-)) how about the examples? Which ones are >>working for you, either in debug mode or in both debug AND release >>mode? >> >>EdB >> >> >> >> >> >>On Wed, Nov 6, 2013 at 4:48 PM, Peter Ent <p...@adobe.com> wrote: >>> I checked a number of files in yesterday and I'm pretty sure a handful >>> won't pass glint right now; I meant to do them all, but forgot some so >>>I'm >>> doing them this morning. If you want to go ahead and run the tool just >>>to >>> see if and how failures pop-up, go right ahead. >>> >>> --peter >>> >>> On 11/6/13 2:40 AM, "Erik de Bruin" <e...@ixsoftware.nl> wrote: >>> >>>>Hi, >>>> >>>>I would like to run the entire JS framework through the 'gjslint' >>>>tool. This is the JS linter provided by Google to check code that is >>>>to be processed by the Closure Compiler. >>>> >>>>It has some very strict whitespace rules, that will result in changes >>>>in most files (although we started out with a clean, gjslint approved >>>>version a long while ago, when I implemented 'goog' event handling). >>>> >>>>The main advantages are that all code will be consistently formatted >>>>and that it will most likely catch some annotation and related >>>>errors/omissions. >>>> >>>>If no one (Alex, Peter) has commits pending, I am ready to go. >>>> >>>>EdB >>>> >>>> >>>> >>>>-- >>>>Ix Multimedia Software >>>> >>>>Jan Luykenstraat 27 >>>>3521 VB Utrecht >>>> >>>>T. 06-51952295 >>>>I. www.ixsoftware.nl >>> >> >> >> >>-- >>Ix Multimedia Software >> >>Jan Luykenstraat 27 >>3521 VB Utrecht >> >>T. 06-51952295 >>I. www.ixsoftware.nl > -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl
